Re: [Xen-devel] [PATCH v10 07/11] libxl/xl: deprecate the build_info->cpumap field

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-06-20 at 18:19 +0200, Dario Faggioli wrote:
> diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> index 7a60ee2..81e77c0 100644
> --- a/tools/libxl/libxl_dom.c
> +++ b/tools/libxl/libxl_dom.c
> @@ -283,9 +283,16 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid,
>                  return ERROR_FAIL;
>              }
>          }
> -    } else if (info->cpumap.size)
> +    } else if (info->cpumap.size) {
> +        /*
> +         * Although info->cpumap is DEPRECATED, we still want old
> +         * applications that may be using it to continue working.
> +         */
> +        LOG(WARN, "cpumap field of libxl_domain_build_info is DEPRECATED. "
> +                  "Please, use the vcpu_hard_affinity array instead");

I think this logging is going too far. It is perfectly valid to be using
this field if the application is interested in compatibility with Xen
4.4 and earlier.

>          libxl_set_vcpuaffinity_all(ctx, domid, info->max_vcpus,
>                                     &info->cpumap, NULL);
> +    }
>  
> 
>      if (xc_domain_setmaxmem(ctx->xch, domid, info->target_memkb +
> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> index 5607ea7..477b2a6 100644
> --- a/tools/libxl/libxl_types.idl
> +++ b/tools/libxl/libxl_types.idl
> @@ -301,7 +301,13 @@ libxl_domain_sched_params = 
> Struct("domain_sched_params",[
>  libxl_domain_build_info = Struct("domain_build_info",[
>      ("max_vcpus",       integer),
>      ("avail_vcpus",     libxl_bitmap),
> -    ("cpumap",          libxl_bitmap),
> +    ("cpumap",          libxl_bitmap), # DEPRECATED!
> +    # The cpumap field above has been deprecated by the introduction of the
> +    # vcpu_hard_affinity array. It is not removed and it is still honoured, 
> for
> +    # API stability and backward compatibility reasons, but should not be 
> used
> +    # any longer. The vcpu_hard_affinity array is what should be used 
> instead.
> +    # As per libxl.h, if both cpumap and vcpu_hard_affinity are used, the 
> latter
> +    # will prevail.

Likewise I think here. Perhaps "DEPRECATED: Use vcpu_hard_affinity"
would be OK. But I'm more inclined to suggest we just drop this entire
patch. After all we can effectively never get rid of this field and
people are entitled to keep using it.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel