Re: [Xen-devel] [PATCH v10 05/11] libxl: Change default for b_info->{cpu, node}map to "not allocated"

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-06-20 at 18:19 +0200, Dario Faggioli wrote:
> by avoiding allocating them in libxl__domain_build_info_setdefault.
> In fact, back in 7e449837 ("libxl: provide _init and _setdefault for
> libxl_domain_build_info") and a5d30c23 ("libxl: allow for explicitly
> specifying node-affinity"), it was decided that the default for these
> fields was for them to be allocted and filled.

"allocated"

> Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> +     * updated accordingly; if it does not manage, inf->nodemap is just left

info-> ?

> +     * alone. It is then the the subsequent call to
> +     * libxl_domain_set_nodeaffinity() that enacts the actual placement.
>       */
>      if (libxl_defbool_val(info->numa_placement)) {
> -        if (!libxl_bitmap_is_full(&info->cpumap)) {
> +        if (info->cpumap.size) {

Not for now but a helper for this might be nice on day.

>              LOG(ERROR, "Can run NUMA placement only if no vcpu "
> -                       "affinity is specified");
> +                       "affinity is specified explicitly");

OOI, this says "Can run", I think what it really means is "I will run"?
No change needed just curious.

I'll fix the two typos on commit, assuming nothing in the remainder of
the series requires a resend.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel