Re: [Xen-devel] [PATCH v01 2/3] xen/arm: add platform specific definitions for DRA7 evm board

[Andrii Tseglytskyi <andrii.tseglytskyi@xxxxxxxxxxxxxxx>]

Hi Julien,

Thank you for review.

On Thu, Jun 26, 2014 at 7:40 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> Hi Andrii,
>
>> +           __pa(init_secondary), init_secondary);
>> +#endif
>> +    writel(__pa(init_secondary), wugen_base + DRA7_AUX_CORE_BOOT_1_OFFSET);
>> +#ifndef NDEBUG
>> +    printk("Set AuxCoreBoot0 to 0x20\n");
>> +#endif
>
> I think those 2 printk would be useful even in non-debug mode. If you
> don't want to print them all the time, you can use
> printk(XENLOG_DEBUG "your msg")
>

OK

>> +    writel(0x20, wugen_base + DRA7_AUX_CORE_BOOT_0_OFFSET);
>> +
>> +    iounmap(wugen_base);
>> +
>> +    return 0;
>> +}
>> +
>> +static const char const *dra7_dt_compat[] __initdata =
>
> This should be __initconst.
>

OK

>> +PLATFORM_START(dra7, "TI DRA7")
>> +    .compatible = dra7_dt_compat,
>> +    .init_time = dra7_init_time,
>> +    .cpu_up = cpu_up_send_sgi,
>> +    .smp_init = dra7_smp_init,
>> +
>> +    .dom0_gnttab_start = 0x4b000000,
>> +    .dom0_gnttab_size = 0x20000,
>> +    .blacklist_dev = dra7xx_blacklist_dev,
>> +PLATFORM_END
>
> Any plan to support reset callback?
>

Sure, in nearest future - yes. But not in this series.

Regards,

-- 

Andrii Tseglytskyi | Embedded Dev
GlobalLogic
www.globallogic.com

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel