Re: [Xen-devel] [PATCH ARM v5 17/20] mini-os: headers for ARM

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Thomas,

On 06/26/2014 12:28 PM, Thomas Leonard wrote:
> diff --git a/extras/mini-os/include/arm/hypercall-arm.h 
> b/extras/mini-os/include/arm/hypercall-arm.h
> new file mode 100644
> index 0000000..6d862ff
> --- /dev/null
> +++ b/extras/mini-os/include/arm/hypercall-arm.h
> +#ifndef __HYPERCALL_ARM_H__
> +#define __HYPERCALL_ARM_H__
> +
> +#include <xen/xen.h>
> +#include <xen/sched.h>
> +#include <xen/xsm/flask_op.h>
> +#include <mini-os/mm.h>

Does all those includes relevant for hypercall-arm?

> diff --git a/extras/mini-os/include/arm/os.h b/extras/mini-os/include/arm/os.h
> new file mode 100644
> index 0000000..bde8796
> --- /dev/null
> +++ b/extras/mini-os/include/arm/os.h

[..]

> +#define BUG() while(1){}

It looks odd to use onely while (1). Shouldn't you call do_exit as x86 does?

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel