[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tools/mce: refactor xen-mceinj to ease injection of other MCEs

David Vrabel writes ("Re: [Xen-devel] [PATCH] tools/mce: refactor xen-mceinj to 
ease injection of other MCEs"):
> On 14/05/14 14:30, David Vrabel wrote:
> > Make the set of MCEs that xen-mceinj can inject by data-driven instead
> > of a whole pile of cut-and-paste functions.
> > 
> > Add two new types of MCE: one for AMD CPUs and one fatal one (PCC
> > set).
> Ping?
> This has been acked by Christoph, one of the MCA maintainers.

Did I miss you addressing Chrisoph's cleanup nit ?

He wrote:

  One little cleanup nit below.
  Other than that:

  Acked-by: Christoph Egger <chegger@xxxxxxxxx>


  malloc + memset = calloc(), please.

Also: strictly speaking it would be better to split out into a
separate patch the removal of the spurious newlines from the error
messages.  Although I won't insist on that, you really ought to
mention it in the commit message!

Also can you please confirm in the commit message that the only
functional change in this patch is the removal of the spurious
newlines (and perhaps a change to the usage output).  If that is _not_
the only functional change then you should explain what else is...


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.