Re: [Xen-devel] [PATCH net v2] xen-netback: bookkeep number of active queues in our own module

[David Miller <davem@xxxxxxxxxxxxx>]

From: Wei Liu <wei.liu2@xxxxxxxxxx>
Date: Sun, 22 Jun 2014 14:31:41 +0100

>  
> +     /* Initialisation completed, tell core driver the number of
> +      * active queues.
> +      */
> +     rtnl_lock();
> +     netif_set_real_num_tx_queues(be->vif->dev, requested_num_queues);
> +     netif_set_real_num_rx_queues(be->vif->dev, requested_num_queues);
> +     rtnl_unlock();
> +
>       xenvif_carrier_on(be->vif);

This function _NEVER_ set the number of RX queues beforehand,
therefore why are you adding an RX queue adjustment now?

Regardless of the reason, you must explain such a change, in
detail, in your commit message.

Your previous patch didn't do this, and I really am suspect as to
whether you functionally tested and verified this aspect of your
change at a ll.

Please don't "quietly" make undescribed changes like this. It's very
tiring to think that a patch has been adjusted to my liking and then
during review I find a grenade like this :-/

Thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel