Re: [Xen-devel] [PATCH v2 2/4] x86: Allow limiting the max C-state sub-state

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.06.14 at 13:16, <ross.lagerwall@xxxxxxxxxx> wrote:
> @@ -484,8 +494,12 @@ static void acpi_processor_idle(void)
>          if ( cx->type == ACPI_STATE_C3 && power->flags.bm_check &&
>               acpi_idle_bm_check() )
>              cx = power->safe_state;
> -        if ( cx->idx > max_cstate )
> -            cx = &power->states[max_cstate];
> +        while ( ( cx->idx > max_cstate ||
> +                ( cx->entry_method == ACPI_CSTATE_EM_FFH &&
> +                  cx->idx == max_cstate &&
> +                  ( cx->address & MWAIT_SUBSTATE_MASK ) > max_csubstate ) ) 
> &&
> +               next_state-- );
> +            cx = &power->states[next_state];

Wouldn't this need switching to using cx->type instead of cx->idx?

Also please put spaces after opening/before closing parentheses
only when those are the outer ones following a keyword.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel