[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v9 6/9] libxl/xl: deprecate the build_info->cpumap field

On mer, 2014-06-18 at 19:11 +0200, Dario Faggioli wrote:
> On mer, 2014-06-18 at 17:44 +0100, Ian Campbell wrote:
> > On Wed, 2014-06-18 at 18:26 +0200, Dario Faggioli wrote:

> > > But does stop allocating the bitmap qualifies as an incompatible API
> > > change?
> > 
> > I don't think so, do you think it might for some reason?
> > 
> Not sure... May an existing application rely on the fact that this is
> being allocated already? I thought it may, but perhaps I'm
> misunderstanding when exactly _setdefaults() is supposed to be called.
> If existing apps do as xl, then it's not an issue to change the default
> as said above. In fact, in xl, _setdefaults() is called (via
> freemem()->libxl_domain_need_memory()) after the config file has been
> parsed already, meaning the user has to allocate cpumap himself if he
> wants to use it. Is this the intended usage? If yes, I'll happily get
> rid of that initializer!
I re-checked the code and re-thought about this issue, and I'm convinced
it actually is a non-issue.

So, yes, I'll change how we handle cpumap (and while at it, nodemap too)
in libxl__build_info_setdefaults(). I'll add a patch to that effect in
v10 of this series.


<<This happens because I choose it to happen!>> (Raistlin Majere)
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.