Re: [Xen-devel] [PATCH v2] tools/libxl: Fix free() of wild pointer in libxl__initiate_device_remove()

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Jun 18, 2014 at 07:09:53PM +0100, Andrew Cooper wrote:
> libxl__initiate_device_remove() had a preexisting error path issue where
> libxl_dominfo_dispose() could be called on a libxl_dominfo object before it
> had been initialised with libxl_dominfo_init().
> 
> This was safe until c/s ab44401 "xl / libxl: push parsing of SSID and CPU pool
> ID down to libxl" added the ssid_label string into libxl_dominfo, which
> libxl_dominfo_dispose() will free().
> 
> Unconditionally initialise info in libxl__initiate_device_remove() before
> taking an error path which will free it.
> 
> Coverity-ID: 1223212
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Thanks
Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel