Re: [Xen-devel] [PATCH ARM v4 07/12] mini-os: initial ARM support

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Thomas Leonard, le Wed 18 Jun 2014 16:08:21 +0100, a Ãcrit :
> From: Karim Raslan <karim.allah.ahmed@xxxxxxxxx>
> 
> On ARM, Mini-OS will boot and display some output on the console.
> Tested with:
> 
> make XEN_TARGET_ARCH=arm32 CROSS_COMPILE=arm-linux-gnueabihf- \
>       CONFIG_TEST=y CONFIG_START_NETWORK=n CONFIG_BLKFRONT=n \
>       CONFIG_NETFRONT=n CONFIG_FBFRONT=n CONFIG_KBDFRONT=n \
>       CONFIG_CONSFRONT=n CONFIG_XC=n -j4
> 
> Signed-off-by: Karim Allah Ahmed <karim.allah.ahmed@xxxxxxxxx>
> [talex5@xxxxxxxxx: made x86_64 support work again]
> [talex5@xxxxxxxxx: split into multiple patches]
> [talex5@xxxxxxxxx: re-enabled force_evtchn_callback]
> [talex5@xxxxxxxxx: enable regular console]
> [talex5@xxxxxxxxx: fixed initialisation code:
> - Configure write-back caching in page table. This is needed for
>   reliable hypercalls to Xen (thanks to Julien Grall).
> - Use "client mode" for access control (domains are deprecated,
>   according to ARM Cortex-A Series Programmerâs Guide version 4.0,
>   section 9.6.4).
> - Enable more SCTLR features (icache, branch prediction)]
> [talex5@xxxxxxxxx: use Virtual Count register for monotonic time]
> [talex5@xxxxxxxxx: fixed HYPERVISOR_shutdown]
> [talex5@xxxxxxxxx: get xenstore details from hypervisor]
> [talex5@xxxxxxxxx: use GCC implementation of division]
> [talex5@xxxxxxxxx: include hypervisor.h from os.h, as on x86]
> [talex5@xxxxxxxxx: cleaned up interrupt handlers and threading]
> [talex5@xxxxxxxxx: call exit_thread when a thread returns]
> [talex5@xxxxxxxxx: implemented block_domain for ARM]
> [talex5@xxxxxxxxx: fixed hang when enabling interrupts]
> [talex5@xxxxxxxxx: added -march=armv7-a to flags]
> [talex5@xxxxxxxxx: implemented bitops for ARM]
> [talex5@xxxxxxxxx: CLREX after handling IRQs]
> [talex5@xxxxxxxxx: unbind debug port at shutdown]
> [talex5@xxxxxxxxx: allow unaligned accesses]
> [talex5@xxxxxxxxx: added arch_endian.h for ARM]
> [talex5@xxxxxxxxx: fix zImage header for XSA-95]
> Signed-off-by: Thomas Leonard <talex5@xxxxxxxxx>

It looks good to me, although I haven't reviewed the purely arm parts
such as bootup.  I don't know how I'm supposed to tag it :)

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel