[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] tools/libxc: Fix missing break in xc_domain_bind_pt_irq()

c/s 568da4f8 "pt-irq fixes and improvements" accidentally forgot a break when
refactoring xc_domain_bind_pt_irq() which results in bind->u.pci.bus being
clobbered by isa_irq for PCI and MSI_TRANSLATE interrupts.

Coverity-ID: 1223210
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
 tools/libxc/xc_domain.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
index ef470a5..d5d6d12 100644
--- a/tools/libxc/xc_domain.c
+++ b/tools/libxc/xc_domain.c
@@ -1711,6 +1711,7 @@ int xc_domain_bind_pt_irq(
         bind->u.pci.bus = bus;
         bind->u.pci.device = device;
         bind->u.pci.intx = intx;
+        break;
     case PT_IRQ_TYPE_ISA:
         bind->u.isa.isa_irq = isa_irq;

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.