Re: [Xen-devel] [PATCH] xen/arm: Panic when we receive an unexpected trap

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-06-17 at 21:44 +0100, Julien Grall wrote:
> The current implementation of do_unexpected_trap make Xen spin forever
> on the current physical CPU. This may lead to stall guests VCPU and print
> unhelpful message (RCU stall...).
> 
> Usually when Xen receives an unexpected trap, it means that something goes
> wrong either in the hypervisor or in the CPU. In this case we should
> directly panic to also stop the other CPUs.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>

Ack + applied.

> ---
>  xen/arch/arm/traps.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
> index ac3fc70..0abb6ff 100644
> --- a/xen/arch/arm/traps.c
> +++ b/xen/arch/arm/traps.c
> @@ -999,7 +999,7 @@ void do_unexpected_trap(const char *msg, struct 
> cpu_user_regs *regs)
>  {
>      printk("CPU%d: Unexpected Trap: %s\n", smp_processor_id(), msg);
>      show_execution_state(regs);
> -    while(1);
> +    panic("CPU%d: Unexpected Trap: %s\n", smp_processor_id(), msg);
>  }
>  
>  typedef register_t (*arm_hypercall_fn_t)(



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel