[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v7 4/9] libxl/gentypes.py: don't generate default values

On Tue, 2014-06-17 at 10:32 +0100, Wei Liu wrote:
> If a field:
>     0. is not of aggregate type
> and
>     1. is of array type and the array is not empty
> or  2. is of a type which has init_val and has been set to init_val,
> or  3. is of builtin type and has been set to internal default value,
> or  4. has been set to 0

This isn't quite true, since #4 depends on their being no init_val.
Prepend "is of a type which has no init_val and "?

> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Other than that: Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.