[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 16/21] xen/arm: split vgic driver into generic and vgic-v2 driver

On 18/06/14 04:33, Vijay Kilari wrote:
On Tue, Jun 17, 2014 at 6:51 PM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
On Thu, 2014-06-12 at 19:06 +0530, vijay.kilari@xxxxxxxxx wrote:
+extern int vgic_to_sgi(struct vcpu *v, register_t sgir,
+                       enum gic_sgi_mode irqmode, int virq,
+                       unsigned long vcpu_mask);

No externs in C files please. Put them in the appropriate header.

OK. I remember why I placed this here.
The enum gic_sig_mode is defined in gic.h and used by both gic and vgic
C files.  So this function declaration in vgic.h requires gic.h and
gic.h requires vgic.h.
So there is cross dependency between vgic.h and gic.h file

Solution is to move enum gic_sgi_mode to vgic.h which I will take care

enum gic_sgi_mode belongs to gic.h not vgic.h. Please use a forward declaration in vgic.h.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.