[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v7 11/19] x86/VPMU: Interface for setting PMU mode and flags

>>> On 17.06.14 at 17:01, <boris.ostrovsky@xxxxxxxxxx> wrote:
> I have a question though. I want to add a compat check for
> struct xen_pmu_arch {
>      union {
>          struct cpu_user_regs regs;
>          uint8_t pad[256];
>      } r;
>      union {
>          uint32_t lapic_lvtpc;
>          uint64_t pad;
>      } l;
>      union {
>          struct xen_pmu_amd_ctxt amd;
>          struct xen_pmu_intel_ctxt intel;
>          uint8_t pad[128];
>      } c;
> };
> which is a shared structure (i.e. it's not used across a hypercall). The 
> problem I am having is that cpu_user_regs needs to be translated. Does 
> the xlat framework allow checking a structure that needs one of its 
> fields translated? I went through the scripts and it appears that it 
> doesn't.

Indeed this is an all-or-nothing thing. Naming (and perhaps splitting
out) the latter two sub-unions may allow checking them individually


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.