Re: [Xen-devel] [PATCH 3/4] xen: separate a function merge_free_trunks from

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.06.14 at 13:49, <lliubbo@xxxxxxxxx> wrote:

Truncated subject?

> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -827,73 +827,14 @@ static int reserve_offlined_page(struct page_info *head)
>      return count;
>  }
>  
> -/* Free 2^@order set of pages. */
> -static void free_heap_pages(
> +/* Caller must hold heap lock */
> +static void merge_free_trunks(
>      struct page_info *pg, unsigned int order, bool_t need_scrub)

From a purely abstract pov this function shouldn't need a "need_scrub"
parameter.

>  {
> -    unsigned long mask, mfn = page_to_mfn(pg);
> -    unsigned int i, node = phys_to_nid(page_to_maddr(pg)), tainted = 0;
> +    unsigned long mask;
> +    unsigned int node = phys_to_nid(page_to_maddr(pg));

Instead, the caller already calculated "node", which hence could be
passed in.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel