Re: [Xen-devel] [PATCH v5 08/21] xen/arm: use device api to detect GIC version

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-06-12 at 19:06 +0530, vijay.kilari@xxxxxxxxx wrote:
>  
> -#define DT_MATCH_GIC    DT_MATCH_COMPATIBLE("arm,cortex-a15-gic"), \
> -                        DT_MATCH_COMPATIBLE("arm,cortex-a7-gic")
> +#define DT_MATCH_GIC_V2_STRING_1     "arm,cortex-a15-gic"
> +#define DT_MATCH_GIC_V2_STRING_2     "arm,cortex-a7-gic"

Please can you name these DT_COMPAT_GIC_CORTEX_A15 / A7.

i.e. s/MATCH/COMPAT/ (because that suits the other use which is made
better) and explicitly naming the processors rather than just string-N.
With the processor names in place I think you can safely drop the V2
from these (but not from DT_MATCH_GIC_V2 below).

With that changed: Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Ian.

> +
> +#define DT_MATCH_GIC_V2 DT_MATCH_COMPATIBLE(DT_MATCH_GIC_V2_STRING_1), \
> +                        DT_MATCH_COMPATIBLE(DT_MATCH_GIC_V2_STRING_2)
>  
>  /*
>   * GICv2 register that needs to be saved/restored



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel