Re: [Xen-devel] [PATCH v5 4/7] xen: Put EFI machinery in place

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Mon, Jun 16, 2014 at 01:00:29PM +0100, David Vrabel wrote:
> On 13/06/14 18:00, Daniel Kiper wrote:
> >
> > v5 - suggestions/fixes:
>
> Put after a --- marker.

Why?

You mean:

---

v5 - suggestions/fixes:
...

> > +static efi_char16_t vendor[100] __initdata;
>
> Why 100?

Well... Quite arbitrary value. The same thing is used in
arch/x86/platform/efi/efi.c:efi_init(). Sadly UEFI sepec
says nothing about maximum vendor name length.

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel