[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 1/4] xentrace: Use PERROR from xc_private. instead of our own.

On Mon, Jun 16, 2014 at 12:49:25PM +0100, Andrew Cooper wrote:
> On 16/06/14 12:43, George Dunlap wrote:
> > On 06/13/2014 09:41 PM, Konrad Rzeszutek Wilk wrote:
> >> However, the xc_private PERROR uses 'xch' while we call said
> >> structure 'xc_handle' - so this patch also changes the variable
> >> to xch.
> >>
> >> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> >
> > I wasn't sure whether "xc_private.h" was intended to be included by
> > tools outside the libxc directory, but it seems to be included by
> > xenpaging and a couple of random things inside tools/misc; so:
> >
> > Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> I disagree - xc_private.h is private to libxc and should not be used
> outside of tools/libxc/*
> There are some naughty examples which should be fixed.
> If there are bits in xc_private.h which are needed by outside programs,
> then they should move to xen{ctrl,guest}.h as appropriate.

Heh. All of this started with me wanting to have 'DIV_ROUNDS_UP' being
a header shared between libxc and xentrace.

It can be in the 'xc_bitsops.h" or in the "trace.h" file. Ian Campbell
didn't want in xc_bitops.h so would "trace.h" file be OK?

> ~Andrew

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.