[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 1/4] xentrace: Use PERROR from xc_private. instead of our own.

On Mon, 2014-06-16 at 12:43 +0100, George Dunlap wrote:
> On 06/13/2014 09:41 PM, Konrad Rzeszutek Wilk wrote:
> > However, the xc_private PERROR uses 'xch' while we call said
> > structure 'xc_handle' - so this patch also changes the variable
> > to xch.
> >
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> I wasn't sure whether "xc_private.h" was intended to be included by 
> tools outside the libxc directory, but it seems to be included by 
> xenpaging and a couple of random things inside tools/misc;

Despite this it's really not supposed to be used outside of libxc
itself. We'd like to get rid of those included with time. Things outside
of libxc itself should use the xtl_* interface I think.

>  so:
> Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.