Re: [Xen-devel] [PATCH v5 3/6] xen/arm: observe itargets setting in vgic_enable_irqs and vgic_disable_irqs

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 12/06/14 15:42, Stefano Stabellini wrote:
> > > +        tr = (1 << v->domain->max_vcpus) - 1;
> > > +        tr = tr | (tr << 8) | (tr << 16) | (tr << 24);
> > > +        tr &= *r;
> > > +        /* ignore zero writes */
> > > +        if ( !tr )
> > > +            goto write_ignore;
> > > +        if ( dabt.size == 2 &&
> > > +            !((tr & 0xff) && (tr & (0xff << 8)) &&
> > > +             (tr & (0xff << 16)) && (tr & (0xff << 24))))
> > > +            goto write_ignore;
> > I quite difficult to understand this check. Does this check is only for
> > word-access?
> The previous test covers byte-access after the change of the following
> patch. I should move it to this patch to make it clearer.
Yes please.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel