Re: [Xen-devel] [PATCH v8 10/13] libxl/xl: deprecate the build_info->cpumap field

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Jun 13, 2014 at 02:34:48PM +0100, Wei Liu wrote:
[...]
> >      }
> >      libxl_domain_set_nodeaffinity(ctx, domid, &info->nodemap);
> > -    libxl_set_vcpuaffinity_all(ctx, domid, info->max_vcpus,
> > -                               &info->cpumap, NULL);
> >  
> 
> So you actually remove cpumap handling logic in libxl as well? IMHO this
> is not right.
> 
> Consider older application can set this map and now with the new library
> CPU is not pinned anymore. I think you can effectively transform cpumap
> to vcpu_hard_affinity list in libxl level to avoid functional regression
> if cpumap is set and vcpu_hard_affinity is not set by application. If
> both cpumap and vcpu_hard_affinity are set, vcpu_hard_affinity takes
> precedence.
> 

Acutally you don't need to transform it at all -- just don't remove
the call to libxl_set_vcpuaffinity_all. :-)

Wei.

> Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel