Re: [Xen-devel] [PATCH v5 06/21] xen/arm: segregate and split GIC low level functionality

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-06-12 at 23:44 +0100, Julien Grall wrote:
> Hi Vijay,
> 
> In my answer I prefixed every comments I made on V4 but you didn't 
> address/answer by "From V4".
> 
> I spend lots of time to review carefully every version of series. Please 
> do the same by reading carefully and addressing or answering to our 
> comments. Thank you.

Yes, this is important. In particular if you disagree with a review
comment then it is important to answer and explain why rather than
simply not making the change.

> On 12/06/14 14:36, vijay.kilari@xxxxxxxxx wrote:
> > From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> >
> > GIC driver contains both generic and hardware specific low
> > level functionality in gic.c file.
> >
> > With this patch, low level functionality is moved to separate
> > file gic-v2.c and generic code is kept in gic.c file
> >
> > Callbacks are registered by low level driver with generic driver
> > and are called whereever required.
> 
> Again, whereever doesn't exist in english. What did you intend to mean? 
> "When it's"?

"wherever" is probably what he meant.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel