[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 5/6] xen/PMU: Intercept PMU-related MSR and APIC accesses

On 06/12/2014 02:56 AM, Dietmar Hahn wrote:

+unsigned long long xen_intel_read_pmc(int counter)
+       int err;
+       uint32_t msr;
+       if (counter & (1<<30))
What means the 30? Should be a #define ...?

Bit 30 of the counter determines whether the counter is general-purpose or fixed.

Even though this is used only once I suppose I could make a define for it since there are a couple of other macros like that.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.