Re: [Xen-devel] [Xen-Devel] [PATCH] [GSOC14] refactored mempaging code from xenpaging to libxc.

[Andres Lagar Cavilla <andres@xxxxxxxxxxxxxxxx>]

On Thu, Jun 12, 2014 at 6:55 AM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:

On Thu, 2014-06-12 at 06:49 -0700, Andres Lagar Cavilla wrote:
> On Thu, Jun 12, 2014 at 6:29 AM, Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx> wrote:
> Â Â Â Â On 12/06/14 14:27, Ian Campbell wrote:
> Â Â Â Â > On Thu, 2014-06-12 at 14:22 +0100, Andrew Cooper wrote:
> Â Â Â Â >>> +# mem paging setup
>     >>> +GUEST_SRCS-y         += xc_mem_paging_setup.c
> Â Â Â Â >>> +
> Â Â Â Â >> I don't think you need the comment here. ÂIt is obvious
> Â Â Â Â from the name of
> Â Â Â Â >> the file, although I would suggest you name it
> Â Â Â Â "xc_dom_paging.c" or
> Â Â Â Â >> something a tad less specific.
> Â Â Â Â > xc_dom_* are, for better or worse, generally domain builder
> Â Â Â Â related.
> Â Â Â Â >
> Â Â Â Â > Given the API is xen_mem_paging_* I don't think the name
> Â Â Â Â here is so bad,
> Â Â Â Â > I might be inclined to drop the _setup if there is any
> Â Â Â Â chance of
> Â Â Â Â > anything else being added here.
> Â Â Â Â >
> Â Â Â Â >
>
>
> Â Â Â Â Hmm yes I suppose. ÂI would certainly drop the _setup, but
> Â Â Â Â "xc_mem_paging.c" is fine.
> xc_mem_paging.c is part of libxenctrl and wraps the hypercalls to page
> in, page out etc.

Would it be inappropriate to put this new function in that file then?

Heh, I worked hard to convince Dushyant otherwise. My understanding is that libxenctrl essentially offers domain control hypercall wrappers, and if you want to apply more complex transformations to a domain (like saving it or changing its CPUID policy) you go to libxenguest.

Andres

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel