Re: [Xen-devel] [PATCH 3/8] libxc: allow xc_get/set_hvm_param() to get/set 64-bit values

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-06-10 at 19:07 +0100, David Vrabel wrote:
> HVMOP_get_param and HVMOP_set_param take a uint32_t for the parameter
> index and a uint64_t for the value.  So, make the corresponding libxc
> function take the same types.
> 
> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>

Removes a pleasing number of casts!

I was about to ack and apply but for a stubdom build:
        xc_domain_save.c: In function âxc_domain_saveâ:
        xc_domain_save.c:1736:26: error: passing argument 4 of 
âxc_get_hvm_paramâ from incompatible pointer type [-Werror]
        In file included from xc_private.h:32:0,
                         from xc_domain_save.c:30:
        xenctrl.h:1812:5: note: expected âuint64_t *â but argument is of type 
âlong unsigned int *â
        xc_domain_save.c:1748:26: error: passing argument 4 of 
âxc_get_hvm_paramâ from incompatible pointer type [-Werror]
        In file included from xc_private.h:32:0,
                         from xc_domain_save.c:30:
        xenctrl.h:1812:5: note: expected âuint64_t *â but argument is of type 
âlong unsigned int *â
        cc1: all warnings being treated as errors
        make[3]: *** [xc_domain_save.o] Error 1
        make[3]: *** Waiting for unfinished jobs....
        make[3]: *** wait: No child processes.  Stop.
        make[2]: *** [build] Error 2
        
Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel