Re: [Xen-devel] [Xen-Devel] [PATCH] [GSOC14] refactored mempaging code from xenpaging to libxc.

[Dave Scott <Dave.Scott@xxxxxxxxxx>]

On 12 Jun 2014, at 10:23, Dushyant Behl <myselfdushyantbehl@xxxxxxxxx> wrote:

> This patch is part of the work done under the gsoc project -
> Lazy Restore Using Memory Paging.

[ snip ]

I can only comment meaningfully on this minor part of the diff:

> diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c 
> b/tools/ocaml/libs/xc/xenctrl_stubs.c
> index ff29b47..37a4db7 100644
> --- a/tools/ocaml/libs/xc/xenctrl_stubs.c
> +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
> @@ -521,13 +521,16 @@ CAMLprim value stub_xc_evtchn_reset(value xch, value 
> domid)
>       CAMLreturn(Val_unit);
> }
> 
> -
> -#define RING_SIZE 32768
> -static char ring[RING_SIZE];
> +/*
> + * The name is kept BUF_RING_SIZE, because the name RING_SIZE 
> + * collides with the xen shared ring definitions in io/ring.h
> + */
> +#define BUF_RING_SIZE 32768
> +static char ring[BUF_RING_SIZE];
> 
> CAMLprim value stub_xc_readconsolering(value xch)
> {
> -     unsigned int size = RING_SIZE - 1;
> +     unsigned int size = BUF_RING_SIZE - 1;
>       char *ring_ptr = ring;
>       int retval;
> 

This is fine by me.

Acked-by: David Scott <dave.scott@xxxxxxxxxx>

Cheers,
Dave
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel