Re: [Xen-devel] [PATCH v2 3/8] tools: arm: allocate large pages to guests.

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 11/06/14 17:39, Ian Campbell wrote:
> Previously we would allocate in batches of up to 4GB worth of pages (allocsz
> clamped at 1024*1024 pages) however this would now require 8MB worth of start
> for the extents array in populate_one_size. Reduce to just 256*1024 or 1GB
> worth of pages (at level 3) or 2MB of stack.
I think you can drop this paragraph. You are using calloc rather than 
the stack in your patch.
> -    return rc;
> +    for ( pfn = 0; pfn < nr_pfns; pfn++ )
> +        dom->p2m_host[pfn] = base_pfn + pfn;
> +
> +out:
> +    free(extents);
Does free preserve errno? I can't find anything saying it... If so we 
may lose it when there is not enought memory.
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel