Re: [Xen-devel] [PATCH ARM v3 5/7] mini-os: switched initial C entry point to arch_init

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Thomas Leonard, le Wed 11 Jun 2014 11:30:16 +0100, a écrit :
> arch_print_info (a debug print called during start up) was also removed.

Well, this information is quite useful, like start_info etc. pointers.
Please bring it back.

> @@ -87,14 +88,40 @@ static inline void sse_init(void) {
>  #define sse_init()
>  #endif
>  
> +
> +void start_kernel(void);
> +

This shouldn't be needed any more.

> @@ -201,13 +174,12 @@ void stop_kernel(void)
>      /* Reset events. */
...
>  }
>  
> +void arch_do_exit(void);

Ditto.

Apart from that,

Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel