[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [blktap2] fix two 'maybe uninitialized' variables

for which gcc 4.9.0 complains about, like this:

block-qcow.c: In function âget_cluster_offsetâ:
block-qcow.c:431:3: error: âtmp_ptrâ may be used uninitialized in this function 
   memcpy(tmp_ptr, l1_ptr, 4096);
block-qcow.c:606:7: error: âtmp_ptr2â may be used uninitialized in this 
function [-Werror=maybe-uninitialized]
   if (write(s->fd, tmp_ptr2, 4096) != 4096) {
cc1: all warnings being treated as errors
 recipe for target 'block-qcow.o' failed
make[5]: *** [block-qcow.o] Error 1

Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
diff --git a/tools/blktap2/drivers/block-qcow.c 
index d5053d4..c677bc9 100644
--- a/tools/blktap2/drivers/block-qcow.c
+++ b/tools/blktap2/drivers/block-qcow.c
@@ -383,8 +383,8 @@ static uint64_t get_cluster_offset(struct tdqcow_state *s,
                                    int n_start, int n_end)
        int min_index, i, j, l1_index, l2_index, l2_sector, l1_sector;
-       char *tmp_ptr2, *l2_ptr, *l1_ptr;
-       uint64_t *tmp_ptr;
+       char *tmp_ptr2 = NULL, *l2_ptr, *l1_ptr;
+       uint64_t *tmp_ptr = NULL;
        uint64_t l2_offset, *l2_table, cluster_offset, tmp;
        uint32_t min_count;
        int new_l2_table;

<<This happens because I choose it to happen!>> (Raistlin Majere)
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.