[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v7 02/19] VPMU: Mark context LOADED before registers are loaded

>>> On 06.06.14 at 19:59, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 06/06/14 18:39, Boris Ostrovsky wrote:
>> Because a PMU interrupt may be generated as soon as PMU registers are loaded 
>> (or,
>> more precisely, as soon as HW PMU is "armed") we don't want to delay marking
>> context as LOADED until after registers are loaded. Otherwise during 
>> interrupt
>> handling VPMU_CONTEXT_LOADED may not be set and this could be confusing.
>> (Technically, only SVM needs this change right now since VMX will "arm" PMU 
>> later,
>> during VMRUN when global control register is loaded from VMCS. However, both
>> AMD and Intel code will require this patch when we introduce PV VPMU).
>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
>> Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>
>> Reviewed-by: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>
>> Tested-by: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

With this not having seen other comments, does it make sense to
apply this on its own, while you address comments you got on
subsequent patches?

Thanks, Jan

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.