Re: [Xen-devel] [v7 PATCH 08/10] xl: enable getting and setting soft

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On mar, 2014-06-10 at 15:10 +0100, Ian Campbell wrote:
> On Tue, 2014-06-10 at 02:45 +0200, Dario Faggioli wrote:
> 
> $subject is truncated?
> 
I think it is. Sorry, will pay attention this does not happen for next
round.

> > +#define hard_aff_str (argv[optind+2])
> > +#define soft_aff_str (argv[optind+3])
> 
> const char *foo = argv[...] please.
> 
Ok.

> > +    /*
> > +     * Hard affinity is always present. However, if it's "-", all we need
> > +     * is passing a NULL pointer to the libxl_set_vcpuaffinity() call 
> > below.
> > +     */
> > +    if (!strcmp(hard_aff_str, "-"))
> > +        hard = NULL;
> > +    else if (vcpupin_parse(hard_aff_str, &cpumap))
> 
> Perhaps consider consistently using hard instead of &cpumap sometimes
> (likewise below for soft). That seems like it might be clearer (the
> cpumap* are really just stack vars in lieu of a malloc).
> 
ISWYM. Yes, I think I can use hard and soft for these two calls. While
at it, I'm thinking about renaming cpumap to cpumap_hard (i.e., ending
up with *hard-->cpumap_hard, *soft-->cpumap_soft)... Shout if you don't
this to happen in v8. :-)

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel