[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 4/6] tools/libxc: Introduce ARRAY_SIZE() and replace handrolled examples

On Tue, 2014-06-10 at 15:07 +0100, Andrew Cooper wrote:
> xen-hptool and xen-mfndump include xc_private.h.  This is bad, but not trivial
> to fix, so they gain a protective #undef and a stern comment.
> MiniOS leaks ARRAY_SIZE into the libxc namespace as part of a stubdom build.
> Therefore, xc_private.h gains an #ifndef until MiniOS is fixed.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked + Applied.

> --

Triple "-" please, or it doesn't have the desired affect.

> v2: Find more areas of the codebase which are poking at libxc private 
> internals
> v3: Refine how xen-{hptool,mfndump} deal with the namespace issue

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.