[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6 03/18] xl / libxl: push VCPU affinity pinning down to libxl

On Tue, Jun 10, 2014 at 08:59:06AM +0200, Dario Faggioli wrote:
> On Mon, 2014-06-09 at 13:43 +0100, Wei Liu wrote:
> > This patch introduces an array of libxl_bitmap called "vcpu_affinity" in
> > libxl IDL to preserve VCPU to PCPU mapping. This is necessary for libxl
> > to preserve all information to construct a domain.
> > 
> > Also define LIBXL_HAVE_AFFINITY_LIST in libxl.h to mark the change in
> > API.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Cc: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> >
> So, as far as this patch is concerned:
> Acked-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> This clashes (not that badly, but it does) with my soft affinity series,
> that I just resent yesterday night. It's not a big deal, we just need
> two arrays of libxl_bitmap-s instead of just one: one for hard affinity,
> and one for soft affinity. Probably that also means that
> b_info->vcpu_affinity should have to be renamed to something like
> b_info->vcpu_hard_affinity (or b_info->vcpu_hard_aff, or
> b_info->hard_affinity, if we want to try keep it a bit shorter).

I would go for vcpu_hard_affinity. When it comes to interface I prefer
it to be as explicit as possible.

> In any case, if this series goes in first, I'll rebase mine on top of
> this one and respin it. It mine goes in first, Wei, I'm up for modifying
> this patch of yours as described above, if you want/need it of course.

Thanks. I think that will do.


> Just let me know.
> Regards,
> Dario
> -- 
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.