Re: [Xen-devel] [PATCH v2 0/2] vgic emulation and GICD_ITARGETSR

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 6 Jun 2014, Ian Campbell wrote:
> On Tue, 2014-06-03 at 17:04 +0100, Stefano Stabellini wrote:
> > Hi all,
> > this small patch series improves vgic emulation in relation to
> > GICD_ITARGETSR and irq delivery.
> 
> I think this somehow relates to the little discussion on "[PATCH v8
> 13/13] gic_remove_from_queues: take a lock on the right vcpu" is that
> correct?
> 
> Do these two patches need to go in instead of that one? Or as precursors
> to it? Or maybe they are nothing to do with each other?
> 

Patch 13/13 identified the problem but didn't fix it properly, this
series does.
I kept it separately because it doesn't have anything to do with
the removal of the maintenance interrupt.

The only relation between the two series is that I wrote this one on
top of the other.

 
> > 
> > At the moment we don't support irq delivery to vcpu != 0, so prevent the
> > guest from setting itarget to something != 0.
> > vgic_enable_irqs and vgic_disable_irqs currently ignore the itarget
> > settings and just enable/disable irqs on the current vcpu. Fix their
> > behaviour to enable/disable irqs on the vcpu set by itarget, that is
> > always vcpu0 for irq >= 32.
> > 
> > 
> > Stefano Stabellini (2):
> >       xen/arm: ignore guest writes to GICD_ITARGETSR for SPIs
> >       xen/arm: observe itarget setting in vgic_enable_irqs and 
> > vgic_disable_irqs
> > 
> >  xen/arch/arm/vgic.c |   50 
> > ++++++++++++++++++++++++++++++++++++++++++--------
> >  1 file changed, 42 insertions(+), 8 deletions(-)
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel