Re: [Xen-devel] [PATCH v1 2/2] libxl: vcpu-set - allow to decrease vcpu count on overcommitted guests (v2)

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-06-05 at 13:44 -0400, Konrad Rzeszutek Wilk wrote:
> > > -        /* NB: This also limits how many are set in the bitmap */
> > > -        max_vcpus = (max_vcpus > host_cpu ? host_cpu : max_vcpus);
> > 
> > Where did this go?
> 
> No need for it actually. As we already do the action if 'max_vcpus >
> host_cpu' - which is that we return. So in essence that code will set 
> max_vcpus
> to max_vcpus.

What about if dominfo.vcpu_online > max_vcpus? iN that case the
max_vcpus > host_cpu check doesn't occur.

You could be in this state if someone had previously forced overcommit I
think.

> 
> > 
> > >      }
> > >      if (libxl_cpu_bitmap_alloc(ctx, &cpumap, max_vcpus)) {
> > >          fprintf(stderr, "libxl_cpu_bitmap_alloc failed\n");
> > 
> > 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel