Re: [Xen-devel] [PATCH 3.4] xen-netback: allow changing the MAC address of the interface

[Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>]

On Thu, Jun 05, 2014 at 02:58:44PM -0700, David Miller wrote:
> From: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
> Date: Mon,  2 Jun 2014 21:46:20 +0200
> 
> > From: Matt Wilson <msw@xxxxxxxxxx>
> > 
> > Sometimes it is useful to be able to change the MAC address of the
> > interface for netback devices. For example, when using ebtables it may
> > be useful to be able to distinguish traffic from different interfaces
> > without depending on the interface name.
> > 
> > Reported-by: Nikita Borzykh <sample.n@xxxxxxxxx>
> > Reported-by: Paul Harvey <stockingpaul@xxxxxxxxxxx>
> > Cc: netdev@xxxxxxxxxxxxxxx
> > Cc: xen-devel@xxxxxxxxxxxxx
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Signed-off-by: Matt Wilson <msw@xxxxxxxxxx>
> > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> > (cherry picked from commit 4a633a602c26497b8285a202830829d3be007c7b)
> > 
> > Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
> > Tested-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
> > Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> 
> I don't think this is suitable for -stable.
> 
> -stable should be restricted bug fixes for things that either
> are extremely serious, or hit a very huge segment of the user
> base.
> 
> This issue does not quality for either condition.

Yeah, it seems like a new feature to me, I'll drop it from my to-apply
queue.

thanks for the review,

greg k-h

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel