Re: [Xen-devel] [PATCH v10] remus drbd: Implement remus drbd replicated disk

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Shriram Rajagopalan writes ("Re: [PATCH v10] remus drbd: Implement remus drbd 
replicated disk"):
> On Wed, Jun 4, 2014 at 8:39 PM, Yang Hongyang <yanghy@xxxxxxxxxxxxxx> wrote:
>     +    if (ackwait) {
>     +        ioctl(rdd->ctl_fd, DRBD_WAIT_CHECKPOINT_ACK, 0);
>     +        ackwait = 0;
>     +    }
...
> Please get rid of the async execution just to execute a sys
> call.

Are you sure ?  Does this syscall not await network traffic ?

What if the network is broken ?  Might it not then delay indefinitely ?

> Not to mention a fork & exec per sys call,

In fact there is no exec, only a fork.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel