[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/amd: Protect set_cpuidmask() against #GP faults

>>> On 05.06.14 at 13:20, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/cpu/amd.c
> +++ b/xen/arch/x86/cpu/amd.c
> @@ -151,7 +151,7 @@ static void __devinit set_cpuidmask(const struct 
> cpuinfo_x86 *c)
>       static unsigned int extfeat_ecx, extfeat_edx;
>       static unsigned int l7s0_eax, l7s0_ebx;
>       static unsigned int thermal_ecx;
> -     static bool_t skip_l7s0_eax_ebx, skip_thermal_ecx;
> +     static bool_t skip_feat, skip_extfeat, skip_l7s0, skip_thermal;

Please don't drop the _eax_ebx and _ecx suffixes - they're there
for a reason (leaf 7 likely also getting ECX and EDX a bitmap assigned
at some point, and the thermal leaf also having further unused
registers that may become subject to masking later on).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.