Re: [Xen-devel] [PATCH v1 4/5] xentrace: Use xc_cpumask_t when setting the cpu mask (v4)

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2014-06-04 at 18:01 +0100, George Dunlap wrote:
> On 06/04/2014 02:44 PM, Konrad Rzeszutek Wilk wrote:
> > Instead of using an uint32_t. This requires us using the
> > xc_tbuf_set_cpu_mask_array API call that can handle variable
> > sized uint8_t arrays.
> >
> > As this is just swapping over to use the new API, the existing
> > shortcomming when using -c is still present: it can only do up
> > to 32 CPUs.
> >
> > But if '-c' has not been specified it will construct an CPU mask
> > for the full amount of physical CPUs.
> >
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > [v2: Changes per Boris's and Daniel's review]
> > [v3,v4: Change per Boris's review]
> 
> Looks good (saving the reviewed-by because

> I think this should probably be merged into patch 2).

I agree.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel