Re: [Xen-devel] [RFC Patch 3/3] x86, irq: count legacy IRQs by legacy_pic->nr_legacy_irqs instead of NR_IRQS_LEGACY

[Thomas Gleixner <tglx@xxxxxxxxxxxxx>]

On Thu, 5 Jun 2014, Jiang Liu wrote:

> Some platforms, such as Intel MID and mshypv, do not support legacy
> interrupt controllers. So count legacy IRQs by legacy_pic->nr_legacy_irqs
> instead of hard-coded NR_IRQS_LEGACY.

Nice patch set!
 
> Signed-off-by: Jiang Liu <jiang.liu@xxxxxxxxxxxxxxx>
> ---
>  arch/x86/include/asm/i8259.h   |    2 ++
>  arch/x86/kernel/acpi/boot.c    |   13 ++++++------
>  arch/x86/kernel/apic/io_apic.c |   43 
> +++++++++++++++++++++++-----------------
>  arch/x86/kernel/devicetree.c   |   12 +++++------
>  arch/x86/kernel/irqinit.c      |    6 +++---
>  arch/x86/pci/xen.c             |    6 +++---
>  6 files changed, 46 insertions(+), 36 deletions(-)
> 
> diff --git a/arch/x86/include/asm/i8259.h b/arch/x86/include/asm/i8259.h
> index a20365953bf8..fdac75b8782a 100644
> --- a/arch/x86/include/asm/i8259.h
> +++ b/arch/x86/include/asm/i8259.h
> @@ -67,4 +67,6 @@ struct legacy_pic {
>  extern struct legacy_pic *legacy_pic;
>  extern struct legacy_pic null_legacy_pic;
>  
> +#define      nr_legacy_irqs()        (legacy_pic->nr_legacy_irqs)

That wants to be a static inline, please.

Thanks,

        tglx

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel