Re: [Xen-devel] [PATCH v1 2/5] libxc/trace: Add xc_tbuf_set_cpu_mask_array a variant of xc_tbuf_set_cpu_mask (v3)

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 06/04/2014 05:45 PM, George Dunlap wrote:
> On 06/04/2014 02:44 PM, Konrad Rzeszutek Wilk wrote:
> > which uses an xc_cpumap_t instead of a uint32_t. This means
> > we can use an arbitrary bitmap without being limited to the
> > 32-bits the xc_tbuf_set_cpu_mask_array can only do.
> >
> > We also add an macro which can be used by both libxc and
> > xentrace.
> >
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > [v2: Use DIV_ROUND_UP macro as suggested by Daniel]
> > [v3: Use 'int' for bits instead of 'unsigned int' as spotted by Boris]
>
> Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
Oh, sorry -- I meant to say: from what I can tell, at the moment 
xentrace is the only user of xc_tbuf_set_cpu_mask().  The libxc 
interface isn't stable: why not just leave the name 
xc_tbuf_set_cpu_mask() and just change the arguments?  (This would 
obviously involve merging patch 4 into this one as well.)
 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel