Re: [Xen-devel] [PATCH net-next v10 1/7] xen-netback: Move grant_copy_op array back into struct xenvif.

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 04/06/14 15:46, Sergei Shtylyov wrote:
> Hello.
> 
> On 06/04/2014 01:30 PM, Wei Liu wrote:
> 
>> From: "Andrew J. Bennieston" <andrew.bennieston@xxxxxxxxxx>
> 
>> This array was allocated separately in commit ac3d5ac2 ("xen-netback:
>> fix guest-receive-side array sizes") due to it being very large, and a
>> struct xenvif is allocated as the netdev_priv part of a struct
>> net_device, i.e. via kmalloc() but falling back to vmalloc() if the
>> initial alloc. fails.
> 
>> In preparation for the multi-queue patches, where this array becomes
>> part of struct xenvif_queue and is always allocated through vzalloc(),
>> move this back into the struct xenvif.
> 
>    Won't this cause an allocation failure and so break bisection at this
> patch?

No. As Andrew already said: "...falling back to vmalloc() if the
initial alloc. fails."

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel