[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [OSSTEST PATCH 1/3] ts-xen-build-prep: Run the backgrounded resize2fs with ionice



All three of these patches look good to me.

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

On Wed, 2014-06-04 at 12:30 +0100, Ian Jackson wrote:
> We wrap this in
>   ionice -cBest-Effort -n7
> 
> This is an attempt to stop resize2fs from starving builds of IO
> bandwidth.  We have been seeing that some IO-intensive build steps
> (notably, configure) can take unreasonable amounts of time and we
> suspect resize2fs as the culprit.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> ---
>  ts-xen-build-prep |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/ts-xen-build-prep b/ts-xen-build-prep
> index 0e68cd3..05a7857 100755
> --- a/ts-xen-build-prep
> +++ b/ts-xen-build-prep
> @@ -159,7 +159,10 @@ sub lvextend1 ($$$) {
>      if (!$background) {
>       target_cmd_root($ho, $cmd, $timeout);
>      } else {
> -     target_cmd_root($ho, "$cmd >>resizefs.log 2>&1 </dev/null &", 30);
> +     target_cmd_root($ho,
> +                     "ionice -cBest-Effort -n7 ".
> +                     "$cmd >>resizefs.log 2>&1 </dev/null &",
> +                     30);
>      }
>  }
>  



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.