Re: [Xen-devel] [PATCH] libxl: disable usbredirection if spice is disabled

[Fabio Fantoni <fabio.fantoni@xxxxxxx>]

Il 02/06/2014 15:41, Ian Campbell ha scritto:
> On Tue, 2014-05-27 at 17:01 +0200, Fabio Fantoni wrote:
> > Now if usbredirection is enabled in domU's xl cfg is added also
> > if spice is disabled and then usbredirection remain unused.
> > This patch if usbredirection is enabled but spice not disable
> > usbredirection and show a warning.
> >
> > Signed-off-by: Fabio Fantoni <fabio.fantoni@xxxxxxx>
> Ack in principal but:
> > +            LOG(WARN,"usbredirection is used only by spice, spice is disabled"
> > +            "therefore usbredirection is disabled.");
> This misses a space between "disabled" and "therefore" and is also a
> rather long line.
>
> How about just "spice disabled, disabling usbredirection"?
I think is ok.
You can change it in commit (since it is only a change of text 
displayed) or I must send an updated patch?
Thanks for any reply.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel