Re: [Xen-devel] [PATCH V5 27/32] libxl: libxl-json format and load/store configuration functions

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, May 20, 2014 at 04:01:28PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH V5 27/32] libxl: libxl-json format and load/store 
> configuration functions"):
> > Introduce a new format in libxl userdata store called "libxl-json". This
> > format contains the deserialized version of domain configuration of a
> > domain.
> 
> I don't think "deserialised" means what you think it means here.
> JSON is a data structure serialisation format.  So the structure is
> serialised, not deserialised.  But it would be better to just say "the
> JSON version" or some such.
> 

OK.

> I don't think I understand what role these two functions play in the
> public API.  libxl_load_domain_configuration doesn't really "load" a
> configuration; it obtains the configuration of a running domain.  But
> at the moment it doesn't do anything unless store has been called.
> 

How about calling it "retrieve"? I'm pretty bad at naming things.

> I can't see why an application would ever want to call
> libxl_store_domain_configuration.  If it did, what would it mean ?
> 

Xl needs to manipulate domain configuration when it migrates a
domain. The receiving end first modifies domain name to "XX--incoming",
then modifies the name back to "XX".

This kind of application specified behavior (the migration protocol
itself) is certainly not part of libxl, so we need to privode to method
let the application update libxl stored configuration as needed.

Wei.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel