[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v8 05/14] arch/arm: unmap partially-mapped I/O-memory regions

Hi Arianna,

On 25/05/14 11:51, Arianna Avanzini wrote:
This commit changes the interface of apply_p2m_changes() to accept
optionally the pointer to a counter of successfully performed
mappings; such a counter is used only in case of INSERT operation.
If an error is encountered during the operation, and therefore the
mapping is only partially performed, such a counter is useful to
let the caller be able to undo what has just been done.

I don't think you need to introduce another argument to apply_p2m_changes. You can directly call apply_p2m_changes with the whole range.

+int unmap_mmio_regions(struct domain *d,
+                       unsigned long start_gfn,
+                       unsigned long nr_mfns,
+                       unsigned long mfn);

The commit message doesn't mention anything about the addition of unmap_mmio_regions as a new interface.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.