[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86: Expose hypervisor's PVH support via xen_caps

On 05/23/2014 11:00 AM, Andrew Cooper wrote:
On 23/05/14 15:55, Boris Ostrovsky wrote:
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
  xen/arch/x86/setup.c | 5 +++++
  1 file changed, 5 insertions(+)
If the plan is to try and PVH and HVM back into one mode as far as Xen
is concerned, doesn't this become redundant?

Yes, I was thinking about this but we currently don't have (or, rather, I can't think of) a good way to determine whether we can start a PVH guest. We can grep the log but that doesn't feel like a particularly good solution.

One option could be to postpone this patch until 4.5 freezes and see whether we indeed followed up on the plan and if we didn't then integrate it.



diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index b2a808a..59b31b1 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -1462,6 +1462,11 @@ void arch_get_xen_caps(xen_capabilities_info_t *info)
          safe_strcat(*info, s);
          snprintf(s, sizeof(s), "hvm-%d.%d-x86_64 ", major, minor);
          safe_strcat(*info, s);
+        if ( hvm_funcs.pvh_supported )
+        {
+            snprintf(s, sizeof(s), "pvh-%d.%d-x86_64 ", major, minor);
+            safe_strcat(*info, s);
+        }

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.