Re: [Xen-devel] [V15 PATCH 1/2] pvh dom0: Add and remove foreign pages

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.05.14 at 01:30, <mukesh.rathor@xxxxxxxxxx> wrote:
> @@ -688,10 +754,12 @@ ept_set_entry(struct p2m_domain *p2m, unsigned long 
> gfn, mfn_t mfn,
>          ept_p2m_type_to_flags(&new_entry, p2mt, p2ma);
>      }
>  
> -    atomic_write_ept_entry(ept_entry, new_entry);
> +    rc = atomic_write_ept_entry(ept_entry, new_entry, target);
> +    if ( rc )

This should have unlikely() ...

> +        old_entry.epte = 0;
>  
>      /* Track the highest gfn for which we have ever had a valid mapping */
> -    if ( p2mt != p2m_invalid &&
> +    if ( rc == 0 && p2mt != p2m_invalid &&

... and this would then better be "else if()". Both of which could
be adjusted while committing. Beyond that all that's left is to have
Tim's approval.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel