[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v8 04/13] xen/arm: support HW interrupts, do not request maintenance_interrupts

Hi Stefano,

On 22/05/14 13:32, Stefano Stabellini wrote:
+void gic_clear_lrs(struct vcpu *v)
+    int i = 0;
+    unsigned long flags;
+    if ( is_idle_vcpu(v) )
+        return;

It think it would be nice to explain why it's necessary to add these 2 new line (i.e the LRs are not restored for idle VCPU...).

+    spin_lock_irqsave(&v->arch.vgic.lock, flags);
+    while ((i = find_next_bit((const unsigned long *) &this_cpu(lr_mask),
+                              nr_lrs, i)) < nr_lrs) {

Small coding style error, the { should be on a newline.

With this 2 changes:

Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.